llama.cpp releases · · 1 min read

b9553

Mirrored from llama.cpp releases for archival readability. Support the source by reading on the original site.

common : relax sampler name matching (#23744)

  • common : relax sampler name matching

Currently, in some cases, the alternative names for samplers (like
top-k and min-p instead of the canonical top_k and min_p) are
not always recognized by the common_sampler_types_from_names function
in common/sampling.cpp.

This PR changes the signature of this function to remove the bool allow_alt_names flag, and removes all occurences of the flag from call
sites. Therefore, the function will now always match all known names.

I also changed the logic of the function to unconditionally check the
provided sampler names against both the canonical and alternative names,
and to be case-insensitive.

This fixes an issue I was seeing wherein samplers specified in the
llama-server UI were not recognized as valid when the alternative
names were used.

  • add more alt names

  • cont. fix

  • cast to unsigned char for correctness

  • common : unify sampler name mapping

  • annotate canonical vs. alt sampler name mappings per @CISC

  • Update common/sampling.cpp

Co-authored-by: Sigbjørn Skjæret [email protected]

  • common : auto-generate sampler name aliases per @ngxson

  • use merged map for matching

  • use .merge instead of iterating

  • nit: simplify comment

  • nit: use insert everywhere, not index assignment


Co-authored-by: Sigbjørn Skjæret [email protected]

macOS/iOS:

Linux:

Android:

Windows:

openEuler:

  • DISABLED
  • openEuler x86 (310p)
  • openEuler x86 (910b, ACL Graph)
  • openEuler aarch64 (310p)
  • openEuler aarch64 (910b, ACL Graph)

UI:

Discussion (0)

Sign in to join the discussion. Free account, 30 seconds — email code or GitHub.

Sign in →

No comments yet. Sign in and be the first to say something.

More from llama.cpp releases